Page 1 of 1

Feedback link for article doesn't work

Posted: Thu Feb 14, 2019 2:54 pm
by Saavick
hey hey :)

I tried to leave feedback on an article today and noticed a small problem. For articles that don't have any feedback yet, there's a link at the bottom:
Do you have questions about this article or found an error? No comments yet - Click here to leave Feedback for this article! [+]
Judging from the javascript code behind it, it's supposed to unhide the "commentbox" element, but it doesn't seem to do this. I managed to get around it by manually unhiding the element, and then the comment got posted as intended.

Re: Feedback link for article doesn't work

Posted: Fri Feb 15, 2019 9:19 am
by Khuri
Thanks for the info, seems to work from on side though.

What browser/version are you using?

Re: Feedback link for article doesn't work

Posted: Fri Feb 15, 2019 9:40 am
by Saavick
I'm using firefox 65.0.1 (the latest version).

In the developer console it shows the following error when I click the link:
SyntaxError: unterminated regular expression literal
Changing the href like so fixes it for me:
href="javascript:hideunhide(document.getElementById('commentlink'),document.getElementById('commentbox'));"
(I removed the slash after the semi colon.)

Re: Feedback link for article doesn't work

Posted: Mon Feb 18, 2019 9:59 am
by Khuri
Sorry, my bad.
When you said "articles" I checked the actual articles and not the guides where it happened.

Fixed it, thank you! :)

Re: Feedback link for article doesn't work

Posted: Mon Feb 18, 2019 12:33 pm
by Saavick
I hadn't considered they were different things, oops :)
Thanks for the fix :heart: